Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert "container cleanup" log message from INFO to DEBUG type #997

Merged
merged 1 commit into from
Aug 3, 2023
Merged

Convert "container cleanup" log message from INFO to DEBUG type #997

merged 1 commit into from
Aug 3, 2023

Conversation

Pexers
Copy link
Contributor

@Pexers Pexers commented Aug 2, 2023

Just as described in #996, converting the bellow log message from INFO to DEBUG type will prevent it from being logged every 5 minutes on the Jenkins logs.

Jul 30, 2023 12:48:31 PM INFO com.nirima.jenkins.plugins.docker.DockerContainerWatchdog processCloud
Will not cleanup superfluous containers on DockerCloud [name=docker, dockerURI=unix:///var/run/docker.sock], as it is disabled
Jul 30, 2023 12:53:31 PM INFO com.nirima.jenkins.plugins.docker.DockerContainerWatchdog processCloud
Will not cleanup superfluous containers on DockerCloud [name=docker, dockerURI=unix:///var/run/docker.sock], as it is disabled
...

This message generates unnecessary noise, thus potentially obscuring developers from reading other logs with higher importance.

Testing done

Submitter checklist
Beta Give feedback

@Pexers Pexers requested a review from a team as a code owner August 2, 2023 21:38
@Pexers Pexers changed the title Converting "container cleanup" message from INFO to DEBUG type Converting "container cleanup" log message from INFO to DEBUG type Aug 2, 2023
MarkEWaite
MarkEWaite approved these changes Aug 3, 2023
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MarkEWaite MarkEWaite merged commit 9d51578 into jenkinsci:master Aug 3, 2023
15 checks passed
@MarkEWaite MarkEWaite added the chore Reduce effort required to maintain label Aug 3, 2023
@Pexers Pexers deleted the fix-cleanup-message branch August 12, 2023 23:54
@MarkEWaite MarkEWaite changed the title Converting "container cleanup" log message from INFO to DEBUG type Convert "container cleanup" log message from INFO to DEBUG type Sep 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

Assignees
No one assigned
Labels
chore Reduce effort required to maintain
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Pexers @MarkEWaite